Update API for suppress image #27796
Merged
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Georges-GNM
approved these changes
Feb 24, 2025
|
Overdue on FRONTS-PROD, ADMIN-PROD (merged by @abeddow91 30 minutes and 6 seconds ago) What's gone wrong? |
|
Seen on ADMIN-PROD (merged by @abeddow91 3 hours, 7 minutes and 54 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @abeddow91 3 hours, 8 minutes and 1 second ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
There has been a change to collections model (guardian/facia-tool#1762 and guardian/facia-scala-client#342) whereby suppressImage value is now kept on the displayHint object rather than on the collection config.
This PR bumps FAPI and CAPI and updates the logic such that suppressImage is retrieved from displayHint.
Screenshots
Checklist
data/databasefiles generated by tests are committed with this PR (the tests will fail in CI if you've forgotten to do this)